Missing Closing Tags

Featured Theme Forums Bootville Missing Closing Tags

This topic contains 13 replies, has 2 voices, and was last updated by  zeaks 2 months ago.

Viewing 14 posts - 1 through 14 (of 14 total)
  • Author
    Posts
  • #18146

    mick
    Participant

    On the sidebar widgets, the closing div tags of the panel-body divs appear to be missing? Or it me that’s missing something?

    #18155

    zeaks
    Keymaster

    Hi Mick, I checked the sidebar widgets and there is a closing div for the panel-body. Here’s the html layout for one

    <aside id="recent-posts-2" class="widget widget_recent_entries panel panel-default">
    <div class="panel-heading">
    <h4 class="widget-title panel-title">Recent Posts</h4>
    </div>
    <div class="panel-body">
    <ul>
    <li></li>
    </ul>
    </div><!-- closing panel-body -->
    </aside>
    #18158

    mick
    Participant

    But the ones on this current page appear to be missing the ‘panel-body’ closing tags?
    http://themes.zeaks.org/forums/topic/missing-closing-tags/

    <aside id=”bbp_forums_widget-2″ class=”widget widget_display_forums panel panel-default”>
    <div class=”panel-heading”>
    <h4 class=”widget-title panel-title”>Forum List</h4></div>
    <div class=”panel-body”>

    </aside>

    #18163

    zeaks
    Keymaster

    That could be. The theme used on this site is an early version of bootville lite and many changes were made after it was created. The released version of Bootville Lite is not missing tags

    #18169

    mick
    Participant

    I purchased Bootville 1.4 (not lite) and I’m still having the same problem. Should I have a later version?

    <aside id="recent-posts-2" class="widget widget_recent_entries panel panel-default">
        <div class="panel-heading">
            <h4 class="widget-title panel-title">Recent Posts</h4>
        </div><div class="panel-body">
            <ul>
                <li>
                    <a href="http://localhost/index.php/2016/01/20/hello-world/">Hello world!</a>
                </li>
                <li>
                    <a href="http://localhost/index.php/2013/01/11/markup-html-tags-and-formatting/">Markup: HTML Tags and Formatting</a>
                </li>
            </ul>
    </aside>
    #18170

    zeaks
    Keymaster

    Could you link your site so I can have a look? There is only one version released

    #18174

    mick
    Participant

    My site isn’t published yet but the example I posted was from a clean install with test data.

    This isn’t my site but one that another user on this forum posted, you can see the problem there too:

    http://www.craigdesorcy.com/

    <aside id="recent-posts-2" class="widget widget_recent_entries panel panel-default">		
        <div class="panel-heading">
            <h4 class="widget-title panel-title">Recent Posts</h4></div>
            <div class="panel-body">
                <ul>
                <li>
                    <a href="http://www.craigdesorcy.com/chronic-state-of-fear/">Chronic State of Fear?</a>
                </li>
                
                <li>
                    <a href="http://www.craigdesorcy.com/picking-sides/">Picking Sides</a>
                </li>
            </ul>
    </aside>
    
    #18181

    zeaks
    Keymaster

    When I view it with Chrome developer tools the closing div is there.

    <aside id="recent-posts-2" class="widget widget_recent_entries panel panel-default">
    <div class="panel-heading">
    <h4 class="widget-title panel-title">Recent Posts</h4>
    </div><-- Panel-heading
    <div class="panel-body">
    <ul>
    </ul>
    </div><-- closing panel-body
    </aside>
    #18182

    mick
    Participant

    I can see them there too. But do you see them when you “View Source”?

    #18183

    zeaks
    Keymaster

    I think you’re right, I’ll have to check the original theme. It looks like the panel-heading is closing but it als looks like I forgot to remove a class “div class=”wellll” which should be “well” I’m sure I meant to disable it while testing and forgot to remove it.

    I planned to release an update over the next week I’ll check this out and fix it, thanks for pointing it out I never would of noticed it!

    #18184

    mick
    Participant

    No problem. Thanks for looking into this for me.

    #18195

    zeaks
    Keymaster

    Had to deal with some webhost issues this week, and the few bug fixes are taking longer than expected it’ll be a bit longer before the update but I’m working on it :)

    #18209

    mick
    Participant

    OK Thanks

    #18210

    zeaks
    Keymaster

    This missing closing div is caused when a widget has no title. It’s proving to be difficult to fix. There are some “hacks” I could use but I’d rather not add them to the theme and I’m sure it wouldn’t be approved by WordPress.org for bootville lite.

    Basically when there is no title for the widget such as search or a text widget used for adsense, the before and after title classes are still used.

    I’ll continue to try and figure a work around but since it’s not causing any problems I might need to leave it as is.

Viewing 14 posts - 1 through 14 (of 14 total)

You must be logged in to reply to this topic.